-
Notifications
You must be signed in to change notification settings - Fork 459
extensions: simplifies the platform plug #5109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScarlettGatelyMoore dropped the "make-parameters": ["PLATFORM_PLUG=...
lines yesterday in d1c5ecb#diff-8a03e9a3b9e1e0cfa55b428426f2adc16394d075e8adf80c3f487022e02bb4f6L701.
Is PLATFORM_PLUG
and this PR still needed or can it be dropped?
|
Waiting on #5092 to land first sounds like a good plan. Thanks! |
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)This PR simplifies the desktop command chain approach, also adds support for separate Platform plug which was also used previously.
Better to merge this before #5092