Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make probert buildable again on noble #147

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

ogayot
Copy link
Member

@ogayot ogayot commented May 6, 2024

I was trying to install a freshly built console-conf but it requires probert-network which FTBFS on noble, even when building with nocheck. I decided to fix it.

The main reason for the build failure was files in debian/tmp that were not included in any binary package.

  • nvme.py -> now included in probert-storage
  • os.py -> now included in probert-storage
  • test scripts and test data. This is not clear to me why we ship those in probert-common but doing so fixed the build issue so 🤷
    • dumpe2fs_ext4.out
    • ntfsresize.out
    • ntfsresize_full.out
    • test_filesystem.py
    • test_os.py

When building without nocheck, there were tests failing because:

  • python3-parameterized was not declared as a Build-Depend
    • Added as a Build-Depend now.
  • ntfsresize and os-prober are not installed in the test environment. Technically there are not called as part of the test-suite but we have calls to shutil.which to check their presence.
    • Fixed by mocking calls to shutil.which.

I took the opportunity to mark the test-only build depends as <!nocheck>

@ogayot
Copy link
Member Author

ogayot commented May 6, 2024

I ran into #141 which addresses most of the above but was never merged. Will merge and rebase for the few other fixes.

Copy link
Collaborator

@dbungert dbungert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ogayot ogayot merged commit 4d254b2 into canonical:master May 10, 2024
4 checks passed
@ogayot ogayot deleted the buildable branch May 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants