Type annotate PebbleReadyEvent.workload #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
added a commit
to benhoyt/charmcraft
that referenced
this pull request
Jul 4, 2023
Notes: * Type checkers like the self.on["container"].pebble_ready syntax over the magic self.on.container_pebble_ready shorthand, so go with that. * Unfortunately we need a "type: ignore" on the ops.main() call as main() is a special module+function due to canonical/operator#910. * The "simple" charm will only work with ops>=2.4.1 due to canonical/operator#962. Will ship 2.4.1 imminently. * I've changed the ops version pinning to 2.x (but 2.4 or higher).
|
Minor tweak forgotten from #953, and gets in the way of canonical/charmcraft#1137, so going to merge this so I can ship an |
syu-w
pushed a commit
to canonical/charmcraft
that referenced
this pull request
Jul 4, 2023
This is part of my work in canonical/operator#920. Notes: * Type checkers like the `self.on["container"].pebble_ready` syntax over the magic `self.on.container_pebble_ready` shorthand, so go with that. * Unfortunately we need a "type: ignore" on the ops.main() call as main() is a special module+function due to canonical/operator#910. * The "simple" charm will only work with ops>=2.4.1 due to canonical/operator#962. Will ship 2.4.1 imminently. * I've changed the ops version pinning to 2.x (but 2.4 or higher).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more thing forgotten from #953. This is annoying because it means that charms that use
ops.PebbleReadyEventannotations when handlingpebble-readycan't access any attributes of theworkload, as it doesn't have a type.For example: