Skip to content

(feature): Replace grafana-agent with opentelemetry-collector#82

Merged
Abuelodelanada merged 4 commits into
mainfrom
gagent-otelcol
Jul 18, 2025
Merged

(feature): Replace grafana-agent with opentelemetry-collector#82
Abuelodelanada merged 4 commits into
mainfrom
gagent-otelcol

Conversation

@Abuelodelanada

Copy link
Copy Markdown
Contributor

This PR replaces grafana-agent with otelcol in COS terraform module.

Closing #70 since it is based in the refactored cos module.

How to test it:

Create the buckets in a S3 and run:

terraform init --upgrade
terraform apply -var='s3_secret_key=secret-key' -var='s3_access_key=access-key' -var='s3_endpoint=http://192.168.1.127' \
-var='loki_bucket=loki' -var='model=cos' -var='mimir_bucket=mimir' -var='tempo_bucket=tempo' -var="mimir_coordinator={units=1}" -var="loki_coordinator={units=1}" -var="tempo_coordinator={units=1}" -var="channel=2/edge" -var="anti_affinity=false" -var="internal_tls=0"

@MichaelThamm

Copy link
Copy Markdown
Contributor

Can you run just format-terraform-docs to fix the linting issue

@Abuelodelanada

Copy link
Copy Markdown
Contributor Author

just format-terraform-docs

just format-terraform-docs
error: Justfile does not contain recipe `format-terraform-docs`

And I get the same error the CI gets:

just lint-terraform-docs
sh: 1: terraform-docs: not found
error: Recipe `lint-terraform-docs` failed on line 32 with exit code 127

Should we install something new?

Comment thread terraform/cos/applications.tf
Comment thread terraform/cos/outputs.tf

@MichaelThamm MichaelThamm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor fixes, otherwise looks good!

Co-authored-by: Michael Thamm <mike.thamm@canonical.com>
Signed-off-by: Jose C. Massón <939888+Abuelodelanada@users.noreply.github.com>
@MichaelThamm

Copy link
Copy Markdown
Contributor

just format-terraform-docs

just format-terraform-docs
error: Justfile does not contain recipe `format-terraform-docs`

And I get the same error the CI gets:

just lint-terraform-docs
sh: 1: terraform-docs: not found
error: Recipe `lint-terraform-docs` failed on line 32 with exit code 127

Should we install something new?

I saw you already fixed it. My mistake the recipe was called update-terraform-docs, which I want to rename to format-terraform-docs in the future.

@MichaelThamm MichaelThamm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abuelodelanada Abuelodelanada merged commit bd14959 into main Jul 18, 2025
4 checks passed
@Abuelodelanada Abuelodelanada deleted the gagent-otelcol branch July 18, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants