(feature): Replace grafana-agent with opentelemetry-collector#82
Merged
Conversation
Contributor
|
Can you run |
Contributor
Author
just format-terraform-docs
error: Justfile does not contain recipe `format-terraform-docs`And I get the same error the CI gets: just lint-terraform-docs
sh: 1: terraform-docs: not found
error: Recipe `lint-terraform-docs` failed on line 32 with exit code 127Should we install something new? |
MichaelThamm
requested changes
Jul 18, 2025
MichaelThamm
left a comment
Contributor
There was a problem hiding this comment.
Some minor fixes, otherwise looks good!
Co-authored-by: Michael Thamm <mike.thamm@canonical.com> Signed-off-by: Jose C. Massón <939888+Abuelodelanada@users.noreply.github.com>
Contributor
I saw you already fixed it. My mistake the recipe was called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces grafana-agent with otelcol in COS terraform module.
Closing #70 since it is based in the refactored cos module.
How to test it:
Create the buckets in a S3 and run: