Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPE-5628 Skip set unknown config keys #532

Merged
merged 3 commits into from
Oct 7, 2024
Merged

DPE-5628 Skip set unknown config keys #532

merged 3 commits into from
Oct 7, 2024

Conversation

paulomach
Copy link
Contributor

@paulomach paulomach commented Oct 4, 2024 •
edited
Loading

Issue

  1. When rolling back to revisions with subset of known configuration, the unknown keys are wrongly tried to be dynamically set, which will break the rendered config dict.
  2. Configuration is not always being persisted to disk

Solution

  1. Test config keys for existence in rendered config dict before trying to set them.
  2. Always persist configuration to disk on config change

Tests to follow once this revision get promoted to stable

paulomach
paulomach commented Oct 4, 2024
View reviewed changes
src/charm.py
# if only dynamic config changed, apply it
logger.info("Configuration does not requires restart")
for config in dynamic_config:
if config not in new_config_dict:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 3 lines are the main part

@paulomach paulomach merged commit ac0af47 into main Oct 7, 2024
104 of 105 checks passed
@paulomach paulomach deleted the fix/dpe-5628-config-keys-in-rollback branch October 7, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

@shayancanonical shayancanonical Awaiting requested review from shayancanonical

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulomach @taurus-forever @carlcsaposs-canonical