tests/open_wrapper: Handle the Ubuntu 64-bit time_t apocalypse #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3290 +/- ##
=======================================
Coverage 77.38% 77.39%
=======================================
Files 1063 1063
Lines 67816 67816
=======================================
+ Hits 52482 52488 +6
+ Misses 15334 15328 -6 ☔ View full report in Codecov by Sentry. |
We're *mostly* insulated from this, but our tests need to intercept calls to `open`, which means that we're exposed to some glibc internals that change under `_TIME_BITS=64`. Fortunately umockdev in the archive has already hit this, so adapt that fix to our use.
RAOF
force-pushed
the
MIRENG-401-fix-time64-fallout
branch
from
2290c93 to
7ce2002
Compare
RAOF
force-pushed
the
MIRENG-401-fix-time64-fallout
branch
from
89875a4 to
a4819a9
Compare
Merged
mattkae
pushed a commit
that referenced
this pull request
Mar 28, 2024
We're *mostly* insulated from this, but our tests need to intercept calls to `open`, which means that we're exposed to some glibc internals that change under `_TIME_BITS=64`. Fortunately umockdev in the archive has already hit this, so adapt that fix to our use. Fixes: #3285
mattkae
pushed a commit
that referenced
this pull request
Mar 28, 2024
We're *mostly* insulated from this, but our tests need to intercept calls to `open`, which means that we're exposed to some glibc internals that change under `_TIME_BITS=64`. Fortunately umockdev in the archive has already hit this, so adapt that fix to our use. Fixes: #3285
AlanGriffiths
added a commit
that referenced
this pull request
Apr 3, 2024
We're *mostly* insulated from this, but our tests need to intercept calls to `open`, which means that we're exposed to some glibc internals that change under `_TIME_BITS=64`. Fortunately umockdev in the archive has already hit this, so adapt that fix to our use. Fixes: #3285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're mostly insulated from this, but our tests need to intercept calls to
open, which means that we're exposed to some glibc internals that change under_TIME_BITS=64.Fortunately umockdev in the archive has already hit this, so adapt that fix to our use.
Fixes: #3285