Don't use the same crtc for multiple outputs in a group #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
========================================
Coverage 77.81% 77.82%
========================================
Files 1068 1058 -10
Lines 67571 67175 -396
========================================
- Hits 52583 52281 -302
+ Misses 14988 14894 -94 ☔ View full report in Codecov by Sentry. |
mattkae
requested changes
Mar 5, 2024
| @@ -109,6 +109,19 @@ std::tuple<mgk::DRMModeCrtcUPtr, int> find_crtc_and_index_for_connector( | |||
|
|
|||
| auto const encoders = connector_available_encoders(resources, connector.get()); | |||
|
|
|||
| // This workaround feels like overkill, but I've not fould a better place to implement a fix... | |||
There was a problem hiding this comment.
Minor misspelling: fould -> found
| if (*pcrtc_id == get<0>(skipped_crtc)->crtc_id) | ||
| { | ||
| recent_crtc_ids.erase(pcrtc_id); | ||
| recent_crtc_ids.push_back(get<0>(skipped_crtc)->crtc_id); |
There was a problem hiding this comment.
Should we also remove this from skipped_crtcs?
| // | ||
| // Using "thread_local" as each group of outputs is accessed on its own thread. | ||
| thread_local std::list<u_int32_t> recent_crtc_ids; | ||
| std::list<std::tuple<mgk::DRMModeCrtcUPtr, int>> skipped_crtcs; |
There was a problem hiding this comment.
Why isn't skipped_crtcs also thread_local?
There was a problem hiding this comment.
Because it doesn't have static duration
|
Not needed (yet). C.f. #3248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3238