compositor: Drop vestigial queueing support #3237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing sets this, swap interval is handled client-side with Wayland.
We only use the framedropping codepaths, and `wl_surface`s are specified to work in mailbox mode (ie: framedropping) mode. We don't need the (unused!) ability to switch to a queueing mode, nor do we need to be able to flush the (unused!) queues.
…hod. This is unused, except for a low-value “destroys its buffers on destruction” test case (and tests that explicitly test `advance_schedule`, of course)
Since `MultiMonitorArbiter` no longer needs to switch between queueing and mailbox modes, *and* mailbox is trivial to implement, we can just have `MultiMonitorArbiter` handle the mailbox directly and drop a layer of indirection.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3237 +/- ##
==========================================
- Coverage 77.84% 77.72% -0.13%
==========================================
Files 1072 1067 -5
Lines 75154 67121 -8033
==========================================
- Hits 58504 52168 -6336
+ Misses 16650 14953 -1697 ☔ View full report in Codecov by Sentry. |
AlanGriffiths
requested changes
Feb 19, 2024
There's no need break ABI here. Co-authored-by: Alan Griffiths <[email protected]>
mattkae
pushed a commit
that referenced
this pull request
Mar 27, 2024
compositor: Drop vestigial queueing support
mattkae
pushed a commit
that referenced
this pull request
Mar 27, 2024
compositor: Drop vestigial queueing support
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to be able to set a per-surface SwapInterval; that's handled client side. Likewise, we don't need to support submitting a queue of buffers to a surface; Wayland specifies mailbox¹ semantics.
Drop some of the infrastructure needed to support these features we no longer use anywhere (including QtMir)
¹: ie: framedropping