DesktopFileManager::resolve_app_id should not return an app id with a .desktop file suffix
#3608
Assignees
Labels
triaged
Triage into JIRA to plan it in
Comments
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 3, 2024
# rc1
* New upstream release 2.19.0
- ABI summary:
. miral ABI unchanged at 7
. mircommon ABI unchanged at 10
. mircore ABI unchanged at 2
. miroil ABI unchanged at 5
. mirplatform ABI bumped to 30
. mirserver ABI bumped to 61
. mirwayland ABI unchanged at 5
. mirplatformgraphics ABI unchanged at 22
. mirinputplatform ABI unchanged at 9
- Enhancements:
. [x11-kiosk] defer fullscreening of applications until they are placed
once (#3670)
. [x11-kiosk] Ensure windows are placed and repainted on X11 "CONFIGURE"
(#3619)
. [x11-kiosk] change enable-x11 default to true
. Initial atomic-kms platform
. [Wayland] Add support for xdg_activation_v1 (#3639)
. Do not default window size (especially to weird values) (#3623)
. DesktopFileManager::resolve_app_id no longer returns an app id with a
.desktop file suffix (Fixes #3608)
. [Configuration] Split options into global and per-module configuration
(#3590)
- Bugs fixed:
. Ensure we always send an initial output enter (#3680)
. Fix stuck-frame-after-mode-switch bug (#3673)
. Fix rendering of resized XWayland applications with client side
decorations (#3587)
. Aspect ratios shouldn't contain zero (Fixes: #3663)
. Use PkgConfig to find development headers (#3661)
. Fix the inotify event handling in
ReloadingYamlFileDisplayConfig::auto_reload() (#3636)
. The `miral::ConfigFile` "Watcher" can be destroyed before the main
loop (Fixes: #3612)
. [xwayland] Don't allow clients to place X11 windows (#3622)
. Surfaces track scale changes on outputs they appear on. (Fixes: #3552)
. New attached windows need to be placed (#3676)
----
[Test
Plan](https://canonical-mir.readthedocs-hosted.com/latest/how-to/how-to-test-mir-for-a-release/)
### Platforms
|| 24.04 | 24.10 |
|-|-|-|
| gbm-kms |@AlanGriffiths|@AlanGriffiths|
| atomic-kms |@AlanGriffiths|@AlanGriffiths|
| eglstream-kms |@tarek-y-ismail||
| eglstream-kms + gbm-kms hybrid |@tarek-y-ismail||
| x11 |@AlanGriffiths|@AlanGriffiths|
| wayland |@AlanGriffiths|@AlanGriffiths|
| virtual |@AlanGriffiths|@AlanGriffiths|
### Console Providers
|| 24.04 | 24.10 |
|-|-|-|
| vt |@AlanGriffiths|@AlanGriffiths|
| logind |@AlanGriffiths|@AlanGriffiths|
| minimal |@AlanGriffiths||
### Window Manager Examples
|| 24.04 | 24.10 |
|-|-|-|
| --window-manager=floating |@AlanGriffiths|@AlanGriffiths|
| --window-manager=tiling |@AlanGriffiths||
| -kiosk |@AlanGriffiths||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
The
app_idthat is returned byForeignTopLevelManagerV1typically ends with a.desktopsuffix as it currently stands. We did this originally becauseg_app_info_get_idtypically returns the app id this way, although it doesn't have to. In cases where the app id is not found withg_app_info_get_id, we were appending.desktop. We shouldn't do this, as this isn't necessarily correct.The text was updated successfully, but these errors were encountered: