-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mir-on-X] Keys repeated #1471
Comments
I'm suspicious of the thread safety around the Mir-on-X platform. (But might find everything significant runs on a single thread when I take a closer look.) |
I don't think Wayland (including via Xwayland) clients make any use of Mir's server-side auto-repeat, so this shouldn't be affecting anything. |
I've just confirmed it's still a problem. |
This seems entirely down to the Mir-on-X platform. The easiest way to reproduce is to use a Mir server over I'm not sure exactly what triggers it yet, but in this scenario it happens a lot. |
It seems like something is slowing down the thread that handles X11 input. In some cases, this can be slowed down by as much as dozens or hundreds of milliseconds, which then causes a key to appear down long enough to trigger a repeat. I'm tracking down where this is happening. |
Hmm, I've now put X11 events on their own dispatcher and that doesn't seem to help. Maybe XLib is doing something synchronously that is blocking events? |
OK, I've dug into this on both the existing xlib and proposed xcb based X platforms. The key repeats happen because the client doesn't see the release event until long after the press event. But that's because the same is true of the X11 input platform. From my debug session:
These event timestamps are 104ms apart, but the times the events are processed are 5s apart. We could disable the repeats on the client (that ought to be configurable on Alternately we could figure out why the connection is so laggy. I also noticed that the screen repaint is very laggy - typing not shown for over 5 seconds (when I moved the mouse). |
2010: Respect `--enable-key-repeat` with Wayland r=wmww a=AlanGriffiths Uses the existing configuration option to configure clients to disable key repeat. Mitigates: #1471 Co-authored-by: Alan Griffiths <[email protected]>
Still an issue, most noticeable with a remote X11 session. (e.g. |
After a number of XWayland windows are open, quickly typed keys sometimes come out repeated a bunch of times. It only seems to happen when a bunch of XWayland windows are open, but both XWayland and Wayland windows are effected. I suspect this is due to a combination of causes:
EDIT: so far I've only observed this in Mir-on-X.
The text was updated successfully, but these errors were encountered: