Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break down KVM list into header, table and cell components. #1256

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Break down KVM list into header, table and cell components. #1256

merged 1 commit into from
Jun 16, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Broke down KVMList component into logical sub-components:
    • KVMListHeader, which will include the action forms eventually,
    • KVMListTable, which is basically a prop'd MainTable,
      • Each cell is also split into its own component, like with the machine list.
  • Power and OS cells just return "Unknown" for now. They will be handled as a separate issue because they require a bit of extra work to find the relevant host info.
  • Adjusted the meter label padding so it matches default line break spacing.

QA

  • Go to /MAAS/r/kvm.
  • Check that the cell data matches the data in /MAAS/l/kvm, except for Power and OS.

Fixes

Fixes canonical-web-and-design/MAAS-squad#1951

huwshimi
huwshimi approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@huwshimi huwshimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment.

ui/src/app/kvm/views/KVMList/KVMListTable/KVMListTable.js Outdated
content: (
<>
<span>
VM<span style={{ textTransform: "none" }}>s</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this maybe be a utility class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huwshimi Yeah probably. I'll update it now

@Caleb-Ellis Caleb-Ellis force-pushed the kvm-table-breakdown branch from ec7add6 to e7a4f9e Compare June 16, 2020 00:15
@Caleb-Ellis Caleb-Ellis merged commit 5b96e87 into canonical:master Jun 16, 2020
@Caleb-Ellis Caleb-Ellis deleted the kvm-table-breakdown branch June 16, 2020 00:49
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
petermakowski added a commit to petermakowski/maas-ui that referenced this pull request Nov 22, 2022
@petermakowski
refactor(machines): rename selected state canonical#1256
8ebfd01
@petermakowski petermakowski mentioned this pull request Nov 22, 2022
Merged
ndv99 pushed a commit that referenced this pull request Nov 22, 2022
@petermakowski
refactor(machines): rename selected state #1256 (#4572)
6512639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

Assignees

@huwshimi huwshimi

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Caleb-Ellis @huwshimi