Skip to content

Close action form when navigating away from /machines. #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2020
Merged

Close action form when navigating away from /machines. #1075

merged 2 commits into from
May 1, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Close action form when navigating away from /machines

QA

  • Select some machines and choose an action
  • Click to somewhere else that still shows the machine header (e.g. pools, add machine)
  • Check that the action form closes

Fixes

Fixes canonical-web-and-design/MAAS-squad#1906

@Caleb-Ellis Caleb-Ellis merged commit 3995420 into canonical:master May 1, 2020
@Caleb-Ellis Caleb-Ellis deleted the auto-close-form branch May 1, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huwshimi huwshimi huwshimi approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Caleb-Ellis @huwshimi