Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter accordion URL update regression. #1032

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Fix filter accordion URL update regression. #1032

merged 2 commits into from
Apr 24, 2020

Conversation

Caleb-Ellis
Copy link
Contributor

Done

  • Fixed regression in debounce PR where URL would not update when filters from the accordion were selected.

QA

  • Select/unselect some filters from the accordion and check that the URL is updated accordingly.

Fixes

Fixes #1028

anthonydillon
anthonydillon approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and QA 👍

@anthonydillon anthonydillon merged commit 845508e into canonical:master Apr 24, 2020
@Caleb-Ellis Caleb-Ellis deleted the filter-url-fix branch October 28, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydillon anthonydillon anthonydillon approved these changes

Assignees

@anthonydillon anthonydillon

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Machine listing filters no longer reflected in URL
3 participants
@Caleb-Ellis @anthonydillon @sparkiegeek