auth: Add entitlements to LXD entities (part 2: Enrich LXD resources with entitlements) #14748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
This was referenced Jan 6, 2025
Closed
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
11 times, most recently
from
d5f0001 to
3cae833
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
2 times, most recently
from
e653ad9 to
7f5457a
Compare
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
2 times, most recently
from
171b326 to
1a09849
Compare
minaelee
reviewed
Jan 10, 2025
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
1a09849 to
e18b874
Compare
|
@minaelee thanks for the feedbacks. Fixing that right now |
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
4 times, most recently
from
6f763e7 to
c793358
Compare
edlerd
reviewed
Jan 10, 2025
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
…alization This comes from golangci-lint: "Consider preallocating [filterDBBuckets] (prealloc)" But since we use 'continue' statement in the loop, we can't really forecast a preallocation size, so instead we use `make([]*db.StorageBucket, 0)` which is the same as `var .. []*db.StorageBucket` but it stops the linter from complaining... Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
…-group' entities Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
ced5d8b to
970b227
Compare
…entitlements' fields Signed-off-by: Gabriel Mougard <[email protected]>
gabrielmougard
force-pushed
the
feat/auth-dry-run-check-part3
branch
from
970b227 to
4cc2a37
Compare
|
@tomponline auth test passed (it was a simple formatting error with |
tomponline
approved these changes
Jan 28, 2025
tomponline
approved these changes
Jan 28, 2025
|
@gabrielmougard thanks, please update your jira task and epic to reflect this is done now. |
hamistao
pushed a commit
to hamistao/lxd
that referenced
this pull request
Jan 31, 2025
…with entitlements) (canonical#14748) This is the second part of a group of three stacked PRs. * First part: canonical#14745 Signed-off-by: hamistao <[email protected]>
tomponline
added a commit
that referenced
this pull request
Jan 31, 2025
This should fix the issues discussed here: https://chat.canonical.com/canonical/pl/c3bjkis1g3nmbytao6q5gcaxuc This also add entitlement enrichment for API entities that weren't added as part as #14748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of a group of three stacked PRs.
IsFineGrainedfield) #14745