Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent settings form input from submitting multiple requests #818

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Jul 18, 2024

Done

  • Currently clicking the "Save" button in a setting form input will result in two api requests sent to the server. This PR fixes this issue.

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Go to server settings page, edit any config and save. Observe the network tab in the browser and you should only see one request sending the payload to the lxd server.

@webteam-app
Copy link

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@mas-who mas-who merged commit a05c93f into canonical:main Jul 18, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants