Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ticls report upload to prevent a security issue #817

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Remove ticls report upload to prevent a security issue #817

merged 1 commit into from
Jul 15, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Jul 15, 2024

Done

  • Remove ticls report upload to prevent a security issue

@webteam-app
Copy link

Demo

Jenkins

demos.haus

mas-who
mas-who approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@mas-who mas-who left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the context for this PR? Is the security issue originating from TICS or the content of the report we are uploading?

@aaryanporwal
Copy link
Member

aaryanporwal commented Jul 15, 2024 •
edited
Loading

ticls -> tics (commit msg). I know the typo is way funnier but it might dodge grep searches

@edlerd edlerd merged commit dd5e43e into canonical:main Jul 15, 2024
9 checks passed
@edlerd edlerd deleted the remove-tics-upload branch July 15, 2024 09:12
@edlerd
Copy link
Collaborator Author

edlerd commented Jul 15, 2024

What's the context for this PR? Is the security issue originating from TICS or the content of the report we are uploading?

The debug report includes some sensitive information.

github-actions bot pushed a commit that referenced this pull request Jul 15, 2024
workflow: remove all reports for PR #817
1e1098d
@Kxiru
Copy link
Contributor

Kxiru commented Jul 15, 2024

LGMT! Good spot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mas-who mas-who mas-who approved these changes

Assignees
No one assigned
Labels
Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edlerd @webteam-app @aaryanporwal @Kxiru @mas-who