Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure instance yaml form updates after saving changed yaml #760

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Apr 30, 2024

Done

  • Ensure instance yaml form updates after saving changed yaml
  • Ensure instance yaml form resets on cancelling changes in the yaml editor

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • edit instance via yaml editor, save changes. ensure editor shows new values
    • edit instance via yaml editor, cancel changes. ensure editor shows old values

@webteam-app
Copy link

…resets on cancelling changes in the yaml editor

Signed-off-by: David Edler <[email protected]>
@mas-who
Copy link
Collaborator

mas-who commented Apr 30, 2024

LGTM 👍

@edlerd edlerd merged commit c9d3cc6 into canonical:main Apr 30, 2024
12 checks passed
@edlerd edlerd deleted the update-instance-yaml-after-save branch April 30, 2024 15:49
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants