Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix architecture filtering on image selection #755

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Apr 29, 2024

Done

  • fix architecture filtering on image selection, it needs to deal with non-aliased architectures
  • adding test for architecture alias loading

Fixes #753

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • browse images on instance create. Ensure the same architecture filters on the left are available as before.

@webteam-app
Copy link

src/util/architectures.tsx Outdated Show resolved Hide resolved
…ith non-aliased architectures, adding test for this

Signed-off-by: David Edler <[email protected]>
@mas-who
Copy link
Collaborator

mas-who commented Apr 29, 2024

LGTM 👍

@edlerd edlerd merged commit 77f27b3 into canonical:main Apr 29, 2024
12 checks passed
@edlerd edlerd deleted the fix-arch-s390x branch April 29, 2024 10:56
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error report
3 participants