Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance): add name length check for instance name (creation/edit) #747

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Apr 18, 2024

Done

  • Added length validation check for instance name (creation and edit)

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Create a new instance, input some text that is longer than 63 characters in the "Instance name" field, and check that a proper error message appears
    • Edit an existing instance, change the name in the header by inputting some text that is longer than 63 characters and check that a proper error message appears

@webteam-app
Copy link

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the validation and making it reusable.

@lorumic lorumic merged commit eb3881e into canonical:main Apr 18, 2024
10 checks passed
@lorumic lorumic deleted the instance-name-length branch April 18, 2024 14:16
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants