Add image creation from instance snapshot WD-10293

[edlerd]

Done

• Add image creation from instance snapshot
• Avoid overflowing notification content in toast list
• Improve copy of all action buttons on snapshots to say "Edit snapshot", "Delete snapshot" or "Save changes", so they contain a verb and a noun.

Fixes WD-10293

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
   • With a local copy of this branch, run as described here.
2. Perform the following QA steps:
   • open instance detail page > snapshots
   • create a snapshot
   • click publish snapshot
   • confirm modal
   • check under images the new entry and use it to launch a new instance.

[webteam-app]

Demo

Jenkins

demos.haus

[mas-who]

This looks good on the happy paths already. See below a few issues observed from QA:

1. When publishing a image from snapshot, we get a notification that the process has started but no further notifications for success or failure.
2. When trying to publish an image from the same snapshot, the below error occurs
   
   Is it possible to prevent the user from publishing an image in this scenario somehow? Not sure if this is possible but we could also rely on the error message which relates back to point 1.

[mas-who]

Code looks good with just one small nit. I'm not sure why when testing on the demo server the success / failure messages are not coming through, since I can see clearly it's implemented in code and testing it locally the notifications does show.

Edit: I think I was just a little impatient and refreshed the browser before the events came though from the demo server. All good here.