-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix coverage report artifact upload #723
ci: fix coverage report artifact upload #723
Conversation
3419c25
to
205bbe2
Compare
Added some steps to show directory contents within the runner environment. Also updated node to 20 for the coverage job. I think it's still worthwhile to enable manual dispatch for coverage, since it's difficult to replicate the issue, we might need to try a few things and iterate on the main branch |
just doing a test quick on the fork, will merge after |
a2c2bc7
to
9a7bd0f
Compare
Signed-off-by: Mason Hu <[email protected]>
9a7bd0f
to
157833d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, hope this fixes it 🤞
I was able to replicate the issue on my fork and this fixed it there, so chance is high but let's see 😅 |
Done
Fix issue with coverage report artifact upload failing due to build files for
monaco-editor
containing invalid characters.QA