Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix coverage report artifact upload #723

Merged

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Apr 4, 2024

Done

Fix issue with coverage report artifact upload failing due to build files for monaco-editor containing invalid characters.

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Ensure CI passes

@webteam-app
Copy link

@mas-who mas-who force-pushed the allow-manual-dispatch-for-coverage-job branch from 3419c25 to 205bbe2 Compare April 4, 2024 16:33
@mas-who
Copy link
Collaborator Author

mas-who commented Apr 4, 2024

Added some steps to show directory contents within the runner environment. Also updated node to 20 for the coverage job. I think it's still worthwhile to enable manual dispatch for coverage, since it's difficult to replicate the issue, we might need to try a few things and iterate on the main branch

@mas-who mas-who requested a review from edlerd April 4, 2024 16:38
.github/workflows/coverage.yaml Outdated Show resolved Hide resolved
.github/workflows/coverage.yaml Outdated Show resolved Hide resolved
@mas-who
Copy link
Collaborator Author

mas-who commented Apr 4, 2024

just doing a test quick on the fork, will merge after

@mas-who mas-who force-pushed the allow-manual-dispatch-for-coverage-job branch 2 times, most recently from a2c2bc7 to 9a7bd0f Compare April 4, 2024 19:31
@mas-who mas-who force-pushed the allow-manual-dispatch-for-coverage-job branch from 9a7bd0f to 157833d Compare April 4, 2024 20:23
@mas-who mas-who changed the title ci: allow manual dispatch for coverage job ci: fix coverage report artifact upload Apr 4, 2024
@mas-who mas-who requested a review from edlerd April 4, 2024 20:25
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hope this fixes it 🤞

@mas-who
Copy link
Collaborator Author

mas-who commented Apr 4, 2024

LGTM, hope this fixes it 🤞

I was able to replicate the issue on my fork and this fixed it there, so chance is high but let's see 😅

@mas-who mas-who merged commit 02a886d into canonical:main Apr 4, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants