Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to vite 5 #715

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Update to vite 5 #715

merged 1 commit into from
Apr 3, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Mar 27, 2024

Done

  • Update Vite 4 to 5
  • update rollup to unblock s390x build

Fixes WD-8319

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • not needed

@webteam-app
Copy link

@@ -111,6 +111,6 @@
"src/**/*.scss": "stylelint"
},
"resolutions": {
"rollup": "@rollup/wasm-node@4.9.5"
"rollup": "@rollup/wasm-node@4.13.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, so we still need to use wasm-node for rollup to make it work?

@edlerd edlerd merged commit 8788a34 into canonical:main Apr 3, 2024
10 checks passed
@edlerd edlerd deleted the update-vite-5 branch April 3, 2024 10:52
github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants