Add return type to all util functions #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://lxd-ui-650.demos.haus |
mas-who
approved these changes
Feb 15, 2024
edlerd
force-pushed
the
util-return-types
branch
from
77d03a5
to
47fedd1
Compare
Signed-off-by: David Edler <[email protected]>
edlerd
force-pushed
the
util-return-types
branch
from
47fedd1
to
2fed79e
Compare
mas-who
reviewed
Feb 16, 2024
| @@ -259,29 +264,3 @@ export const getAbsoluteHeightBelow = (belowId: string) => { | |||
| parseFloat(style.paddingTop) + parseFloat(style.paddingBottom); | |||
| return element.offsetHeight + margin + padding + 1; | |||
| }; | |||
|
|
|||
| export const getElementAbsoluteHeight = (element: HTMLElement | null) => { | |||
There was a problem hiding this comment.
sorry about these orphan functions!
mas-who
approved these changes
Feb 16, 2024
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done