feat(storage) crud for custom volume snapshots [WD-7576]

[mas-who]

Done

• removed snapshot volume type from volumes list filter.
• clicking on volume name will redirect to instance detail page if it's a container or vm volume, redirect to image list page if it's a image volume and redirect to volume details if it's a custom volume.
• added the snapshots column to the volumes list table. Number of snapshots per volume is calculated based on number of snapshot volumes that matches each volume name.
• CTA for storage volume list table. For custom storage volumes, user can add snapshots or delete volume. For instance volumes, link to instance detail and for image volumes link to images list. Show CTA only on hover volume row.
• Generalised snapshot form modal
• Snapshot form modal will now be rendered using portal
• Added storage volume snapshot api
• Create instance and custom volume snapshots using the generalised snapshot form modal
• Fixed issue with snapshot form modal retaining stale states after snapshot created, this was an issue with instance snapshot as well
• Implemented snapshots tab for storage volume detail page (heavy reference to the snapshots tab for instnace detail page)
• Code cleanup
• Fixed issue with not able to sort by the snapshots column on the storage volume list table
• Fixed issue with disabling snapshot creation if project is restricted

Review Changes

• Fixes based on David's comments:
  • Error handling for instance and volume snapshot creation when project is restricted
  • Moved VolumeSnapshotsForm out of the generic component folder
• Added tests for custom volume snapshot crud
• More changes for David's review:
  • unique naming for instance and volume snapshot api methods
  • removed PortalModalBtn and created addition button components for readability
  • each file should contain one component
  • moved request to get volume snapshots from StorageVolumeDetail to StorageVolumeSnapshots component
  • removed loadCustomVolumeAndSnapshots.tsx as it is not needed
  • removed unecessary refetchOnMount
  • removed description input for custom storage volume snapshots
  • improved logic for determining if snapshot is disabled for the project
  • split snapshots utils into generic, instance and volume specific files
  • updated LxdSyncResponse interface with generic type
  • handle undefined case for isSnapshotDisabled in utils/snapshots.tsx
  • consistent props destructuring for components throughout
  • removed useInstanceSnapshot and useVolumeSnapshot hooks
  • moved NotificationRow below TabLinks in StorageVolumeDetail.tsx
  • improve small screen viewing for storage volumes table with collapsed columns
  • added disable snapshot creation tooltips for instance and volume snapshots
  • minor styling fixes
  • spelling fix
  • moved generateLinkForVolumeDetail from utils file to StorageVolumeNameLink component

QA

1. Run the LXD-UI:
   • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
   • With a local copy of this branch, run as described here.
2. Perform the following QA steps:
   • Navigate to Storage -> Volumes tab: check that clicking on the name of a Container or VM type volume will redirect you to the relevant instance detail page. For a Image type volume, clicking on the name of the volume will redirect you to the images overview page.
   • On volumes tab, CTAs will now be visible on hover. Only custom storage volumes will have localised CTAs (add snapshot and delete volume). Try add a snapshot for a specific volume by clicking on the add snapshot CTA.
   • On storage volumes tab, create a custom volume then navigate to its details page by clicking on the volume's name. Go to the Snapshots tab and check:
     • create, edit and delete snapshots.
     • configure snapshot settings for the volume by clicking on the See configuration button.

[webteam-app]

Demo starting at https://lxd-ui-563.demos.haus

[edlerd]

This already works nicely on all the happy paths. I did a bit of QA and found some rough edges, see below comments for details.

[piperdeck]

Everything looks good to me, great work!

[edlerd]

Thanks for all the changes, this is looking better and better.
Now, I finished the review with some new discoveries, when those are settled this should be ready to merge.

[edlerd]

Thanks for the changes.

Some suggestions for the captions, trying to tailor the copy closer to the setting the user has to flip to enable it.