Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Never" when instance has never been used #539

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Nov 16, 2023

Done

  • Show "Never" when instance has never been used instead of "Jan 1, 1970 ..."

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Go to the detail page of an instance that was never used, e.g. this
    • Check that "Last used" says "Never" instead of "Jan 1, 1970"

@webteam-app
Copy link

Demo starting at https://lxd-ui-539.demos.haus

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing this.

@lorumic lorumic merged commit 6dc24c1 into canonical:main Nov 16, 2023
5 checks passed
@lorumic lorumic deleted the fix-never-used branch November 16, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants