Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use events stream for all long-running operations [WD-6846] #506

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Oct 24, 2023

Done

  • Removed all usages of watchOperation, to generalise the usage of the events stream for all long-running operations.

Fixes WD-6846

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Check that the following operations all work as expected, and that they notify success/failure correctly once completed:
      1. Delete cached image
      2. Instance bulk actions including bulk delete
      3. Project rename
      4. All snapshot operations: create, restore, delete, rename, update and bulk delete
      5. Custom ISO upload

@webteam-app
Copy link

Demo starting at https://lxd-ui-506.demos.haus

Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, test and code looks good.

@edlerd edlerd merged commit e1bbb19 into canonical:main Oct 25, 2023
5 checks passed
@lorumic lorumic deleted the remove-watch-operation branch October 26, 2023 08:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants