Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BaseLayout as main container wherever possible [WD-6364] #479

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Use BaseLayout as main container wherever possible [WD-6364] #479

merged 2 commits into from
Oct 2, 2023

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Oct 2, 2023 •
edited by jira bot
Loading

Done

  • Replaced the main element with the BaseLayout component throughout the app
  • Minor code refactors related to the above change

Fixes WD-6364

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • Check that all the modified pages look as expected in terms of header and content appearance

@lorumic lorumic requested a review from edlerd October 2, 2023 09:13
@webteam-app
Copy link

Demo starting at https://lxd-ui-479.demos.haus

edlerd
edlerd reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, two suggestions below.

src/components/BaseLayout.tsx Outdated Show resolved Hide resolved
src/components/BaseLayout.tsx Show resolved Hide resolved
@lorumic lorumic requested a review from edlerd October 2, 2023 11:25
edlerd
edlerd reviewed Oct 2, 2023
View reviewed changes
src/components/BaseLayout.tsx Show resolved Hide resolved
src/sass/_detail_page.scss Outdated Show resolved Hide resolved
@lorumic lorumic requested a review from edlerd October 2, 2023 13:03
@lorumic lorumic requested a review from edlerd October 2, 2023 14:22
edlerd
edlerd approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@edlerd edlerd merged commit 6c111c3 into canonical:main Oct 2, 2023
5 checks passed
@lorumic lorumic deleted the use-base-layout branch October 26, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorumic @webteam-app @edlerd