-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add storage volume detail page #472
Conversation
Demo starting at https://lxd-ui-472.demos.haus |
e67bea9
to
d4811b5
Compare
5c1b82d
to
836f0f5
Compare
d0ca988
to
9c23492
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
Not sure if this is a result of a change in this particular branch, but it seems like the way that the UI reports that a volume is being used might be broken/misbehaving.
The volume "pool-dir/smol-vol" reports that it is being used by 1 instance:
But when you navigate to that instance, it doesn't report being connected to smol-vol at all:
The volume's name and configurations can't be changed while it's being "used", but I can't figure out how to make it stop being used.
There seem to be two possibilities of what's going on:
- The way in which the UI or core determines that something is attached to it is bugged, and that needs attention.
- The UI can't communicate certain kinds of connections that block volume customization
2
Unless there's a very specific reason why it's named this way, I would name this configuration tab "Filesystem" rather than "Block", since both of these options are specifically filesystem related.
3
This option here could probably benefit from a little bit of support text, and a link to documentation on mount options such as the Ubuntu manpages. Even for experienced users, it could be nice to have a quick reference here.
Hey @piperdeck , thanks for the review! I addressed 2. and 3. Regarding 1.
This PR does not include the UI for attaching volumes to instances yet. You can see the relation in the YAML view already. So the instance is referencing the volume, just the instance>configuration>storage section can't display it yet. That feature is in this PR and still pending because there are a bunch of issues on it. |
d1a8da4
to
a2747b4
Compare
a2747b4
to
0c009c4
Compare
Changes look good to me! |
It still says I requested changes. I'm not sure how to make my request go away without breaking anything.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
@piperdeck if you approve the changes, the request would go away. |
Done
QA