Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide volume snapshot in "Choose custom volume" model #777

Closed
lijunle opened this issue May 22, 2024 · 1 comment · Fixed by #778
Closed

Hide volume snapshot in "Choose custom volume" model #777

lijunle opened this issue May 22, 2024 · 1 comment · Fixed by #778

Comments

@lijunle
Copy link

lijunle commented May 22, 2024

When choose to attach a disk to a container / VM, it opens the "Choose custom volume" model.

Screenshot 2024-05-16 at 01 24 53

The model shows the custom volume with its snapshots. I could expect the snapshot should not be shown here. At least, we should hide them by default and provide a checkbox to show snapshots.

Screenshot 2024-05-16 at 01 25 28

Related code here:

const {
data: volumes = [],
error,
isLoading,
isFetching,
} = useQuery({
queryKey: [queryKeys.customVolumes],
refetchOnMount: (query) => query.state.isInvalidated,
queryFn: () => loadCustomVolumes(project),
});

edlerd added a commit to edlerd/lxd-ui that referenced this issue May 23, 2024
…dd to an instance or profile. only show the custom volumes to select from. fixes canonical#777
@edlerd
Copy link
Collaborator

edlerd commented May 23, 2024

Thank you for reaching out and reporting this issue. Indeed, this is a bug and can be fixed shortly.

edlerd added a commit to edlerd/lxd-ui that referenced this issue May 23, 2024
…dd to an instance or profile. only show the custom volumes to select from. fixes canonical#777

Signed-off-by: David Edler <[email protected]>
mas-who pushed a commit that referenced this issue May 23, 2024
…dd to an instance or profile. only show the custom volumes to select from. fixes #777

Signed-off-by: David Edler <[email protected]>
edlerd added a commit that referenced this issue May 23, 2024
…dd to an instance or profile. only show the custom volumes to select from. fixes #777

Signed-off-by: David Edler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants