Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inputs to promote charm #14

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Move inputs to promote charm #14

merged 2 commits into from
Jul 2, 2024

Conversation

cbartz
Copy link
Collaborator

@cbartz cbartz commented Jul 2, 2024

Applicable spec: n/a

Overview

Move the charm-directory and doc-automation-disabled inputs from the publish charm to promote the charm.

Rationale

The inputs break the publish charm action and must be placed in the promote charm workflow.

Juju Events Changes

n/a

Module Changes

n/a

Library Changes

n/a

Checklist

@cbartz cbartz added bug Something isn't working trivial labels Jul 2, 2024
@cbartz cbartz requested a review from a team as a code owner July 2, 2024 08:02
Copy link

github-actions bot commented Jul 2, 2024

Test coverage for 26996fe

Name                           Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------
webhook_router/__init__.py         0      0      0      0   100%
webhook_router/app.py            103      0     32      0   100%
webhook_router/mq.py              22      0      7      0   100%
webhook_router/parse.py           62      0     22      0   100%
webhook_router/router.py          46      0     18      0   100%
webhook_router/validation.py       6      0      0      0   100%
--------------------------------------------------------------------------
TOTAL                            239      0     79      0   100%

Static code analysis report

Run started:2024-07-02 08:03:22.530549

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1797
  Total lines skipped (#nosec): 8
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147 Thanhphan1147 merged commit 6cce10e into main Jul 2, 2024
18 checks passed
@Thanhphan1147 Thanhphan1147 deleted the fix/publish-charm branch July 2, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working trivial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants