win32: framework implementation for regular windows

.gemini/config.yaml

@@ -11,6 +11,7 @@ code_review:
     # These tend to be verbose, and since we expect PR authors to clearly
     # describe their PRs this would be at best duplicative.
     summary: false
+    include_drafts: false
 ignore_patterns:
   # Avoid code reviews on rolls.
   - DEPS

.gemini/styleguide.md

@@ -5,13 +5,24 @@ flutter/flutter repository. It is based on the more comprehensive official
 [style guide for the Flutter repository](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md).
 
 ## Best Practices
+
 - Code should follow the guidance and principles described in
   [the Flutter contribution guide](https://github.com/flutter/flutter/blob/main/CONTRIBUTING.md).
 - Code should be tested and follow the guidance described in the [writing effective tests guide](https://github.com/flutter/flutter/blob/main/docs/contributing/testing/Writing-Effective-Tests.md) and the [running and writing tests guide](https://github.com/flutter/flutter/blob/main/docs/contributing/testing/Running-and-writing-tests.md).
-- Changes to the [engine/ directory](https://github.com/flutter/flutter/tree/main/engine) should additionally have appropriate tests as described in [the engine test guidance](https://github.com/flutter/flutter/blob/main/engine/src/flutter/docs/testing/Testing-the-engine.md).
+- Changes to the [engine/ directory](https://github.com/flutter/flutter/tree/main/engine) should additionally have appropriate tests as described in [the engine test guidance](https://github.com/flutter/flutter/blob/main/docs/engine/testing/Testing-the-engine.md).
 - PR descriptions should include the Pre-launch Checklist from
   [the PR template](https://github.com/flutter/flutter/blob/main/.github/PULL_REQUEST_TEMPLATE.md),
   with all of the steps completed.
+- The most relevant guidelines should take precedence over less relevant
+  guidelines. For Flutter code, the
+  [Flutter styleguide](https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md)
+  should be followed as the first priority, and
+  [Effective Dart: Style](https://dart.dev/effective-dart/style)
+  should only be followed when it does not conflict with the former.
+
+## Review Agent Guidelines
+
+- Only review changes to the `master` branch. Other changes have already been reviewed (and are being cherrypicked).
 
 ## General Philosophy
 
@@ -50,6 +61,16 @@ flutter/flutter repository. It is based on the more comprehensive official
 - **Provide illustrations or screenshots** for widgets.
 - Use `///` for public-quality documentation, even on private members.
 
+## Review Agent Guidelines
+
+When providing a summary, the review agent must adhere to the following principles:
+- **Be Objective:** Focus on a neutral, descriptive summary of the changes. Avoid subjective value judgments
+  like "good," "bad," "positive," or "negative." The goal is to report what the code does, not to evaluate it.
+- **Use Code as the Source of Truth:** Base all summaries on the code diff. Do not trust or rephrase the PR
+  description, which may be outdated or inaccurate. A summary must reflect the actual changes in the code.
+- **Be Concise:** Generate summaries that are brief and to the point. Focus on the most significant changes,
+  and avoid unnecessary details or verbose explanations. This ensures the feedback is easy to scan and understand.
+
 ## Further Reading
 
 For more detailed guidance, refer to the following documents:
@@ -60,4 +81,4 @@ For more detailed guidance, refer to the following documents:
 - [The Flutter contribution guide](https://github.com/flutter/flutter/blob/main/CONTRIBUTING.md)
 - [Writing effective tests guide](https://github.com/flutter/flutter/blob/main/docs/contributing/testing/Writing-Effective-Tests.md)
 - [Running and writing tests guide](https://github.com/flutter/flutter/blob/main/docs/contributing/testing/Running-and-writing-tests.md)
-- [Engine testing guide](https://github.com/flutter/flutter/blob/main/engine/src/flutter/docs/testing/Testing-the-engine.md)
+- [Engine testing guide](https://github.com/flutter/flutter/blob/main/docs/engine/testing/Testing-the-engine.md)

.github/labeler.yml

@@ -152,7 +152,7 @@ platform-android:
     - any-glob-to-any-file:
       - docs/platform/android/**/*
       - engine/src/flutter/shell/platform/android/**/*
-      - packages/flutter_tools/*android*'
+      - packages/flutter_tools/*android*
       - packages/flutter_tools/gradle/**/*
 
 platform-ios:

.github/workflows/content-aware-hash.yml

@@ -15,9 +15,8 @@ jobs:
 
       - name: Generate Hash
         run: |
-          # IMPORTANT: Keep the list of files in sync with bin/internal/content_aware_hash.sh
-          # We call this directly here as we're expected to be in the merge queue (not master)
-          engine_content_hash=$(git ls-tree --format "%(objectname) %(path)" HEAD -- DEPS engine bin/internal/release-candidate-branch.version | git hash-object --stdin)
+          # Script updated to handle gh-readonly-queue/ branches
+          engine_content_hash=$(bin/internal/content_aware_hash.sh)
           # test notice annotation for retrival from api
           echo "::notice ::{\"engine_content_hash\": \"${engine_content_hash}\"}"
           # test summary writing

.github/workflows/coverage.yml

@@ -23,7 +23,7 @@ jobs:
       - name: ./bin/flutter test --coverage
         run: pushd packages/flutter;../../bin/flutter test --coverage -j 1;popd
       - name: upload coverage
-        uses: codecov/codecov-action@0565863a31f2c772f9f0395002a31e3f06189574
+        uses: codecov/codecov-action@fdcc8476540edceab3de004e990f80d881c6cc00
         with:
           files: packages/flutter/coverage/lcov.info
           verbose: true

.github/workflows/easy-cp.yml

@@ -12,6 +12,20 @@ on:
 permissions: write-all
 
 jobs:
+  cherrypick_not_merged_remove_label:
+    name: cherrypick_not_merged_remove_label
+    runs-on: ubuntu-latest
+    if: |
+      (github.event.label.name == format('cp{0} beta', ':') || github.event.label.name == format('cp{0} stable', ':')) &&
+      (github.event.pull_request.merged == false)
+    steps:
+      - name: Leave Comment and Remove Label
+        run: |
+          gh pr edit ${{ github.event.pull_request.number }} --remove-label "cp: beta"
+          gh pr edit ${{ github.event.pull_request.number }} --remove-label "cp: stable"
+          gh pr comment ${{ github.event.pull_request.number }} -R flutter/flutter -b "Only merged pull requests can be cherrypicked."
+        env:
+          GITHUB_TOKEN: ${{ secrets.FLUTTERACTIONSBOT_CP_TOKEN }}
   cherrypick_to_release:
     name: cherrypick_to_release
     runs-on: ubuntu-latest
@@ -50,10 +64,6 @@ jobs:
           git fetch upstream master
           git checkout -b cp-${CHANNEL}-${COMMIT_SHA} --track upstream/$RELEASE_BRANCH
           git cherry-pick $COMMIT_SHA
-      # TODO(xilaizhang): remove this step once the template is available on release branches.
-      - name: Get CP Template
-        run: |
-          curl -o PULL_REQUEST_CP_TEMPLATE.md https://raw.githubusercontent.com/flutter/flutter/main/.github/PR_TEMPLATE/PULL_REQUEST_CP_TEMPLATE.md
       - name: Create PR on CP success
         if: ${{ steps.attempt-cp.conclusion == 'success' }}
         working-directory: ./flutter
@@ -62,7 +72,7 @@ jobs:
           git push https://${{ env.GITHUB_TOKEN }}@github.com/flutteractionsbot/flutter cp-${CHANNEL}-${COMMIT_SHA}
           {
             echo 'PR_URL<<EOF'
-            gh pr create --title "[CP-${CHANNEL}]${PR_TITLE}" --body-file ../PULL_REQUEST_CP_TEMPLATE.md --base ${RELEASE_BRANCH} --label "cp: review" --repo flutter/flutter --head flutteractionsbot:cp-${CHANNEL}-${COMMIT_SHA}
+            gh pr create --title "[CP-${CHANNEL}]${PR_TITLE}" --body-file ".github/PR_TEMPLATE/PULL_REQUEST_CP_TEMPLATE.md" --base ${RELEASE_BRANCH} --label "cp: review" --repo flutter/flutter --head flutteractionsbot:cp-${CHANNEL}-${COMMIT_SHA}
             echo EOF
           } >> "$GITHUB_ENV"
         env:

.github/workflows/labeler.yml

@@ -17,6 +17,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     # Source available at https://github.com/actions/labeler/blob/main/README.md
-    - uses: actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9
+    - uses: actions/labeler@634933edcd8ababfe52f92936142cc22ac488b1b
       with:
         sync-labels: true

CHANGELOG.md

@@ -29,6 +29,43 @@ Our goal is to make the list easy for them to scan.
 More information and tips:
 docs/releases/Hotfix-Documentation-Best-Practices.md
 -->
+
+## Flutter 3.35 Changes
+
+### [3.35.4](https://github.com/flutter/flutter/releases/tag/3.35.4)
+- [flutter/173474](https://github.com/flutter/flutter/issues/173474) - On all platforms PlatformDispatchers.instance.engineId no longer returns null after hot restart.
+- [flutter/174513](https://github.com/flutter/flutter/issues/174513) - On iOS 26, fix a bug where platform view's gesture blocking fails and lets touches on Flutter views fall through to underlying platform views.
+
+### [3.35.3](https://github.com/flutter/flutter/releases/tag/3.35.3)
+
+- [flutter/172627](https://github.com/flutter/flutter/issues/172627) - Unnecessary output is printed in non-verbose mode.
+- [flutter/173917](https://github.com/flutter/flutter/issues/173917) - On Android, `flutter build apk` may fail to calculate the version code when using `--build-number`.
+- [flutter/174437](https://github.com/flutter/flutter/issues/174437) - When running a Flutter web application in debug mode, the console is spammed with non-fatal error messages.
+- [flutter/174267](https://github.com/flutter/flutter/issues/174267) - Golden test failures can cause the test harness to stall.
+- [flutter/171691](https://github.com/flutter/flutter/issues/171691) - A race condition can cause crashes in the Impeller Vulkan back end.
+- [flutter/174100](https://github.com/flutter/flutter/issues/174100) - Superellipses may not render correctly when using Impeller.
+- [flutter/174015](https://github.com/flutter/flutter/issues/174015) - Obsolete warning and error messages are shown when switching between build modes in Xcode.
+
+### [3.35.2](https://github.com/flutter/flutter/releases/tag/3.35.2)
+
+- [flutter/173823](https://github.com/flutter/flutter/issues/173823) - On Android builds that do not use flutter.minSdkVersion and do use a value lower than 24 in a kotlin build file, correct flutters auto migration to update value with kotlin syntax.
+- [flutter/173741](https://github.com/flutter/flutter/issues/173741) - Fixes an issue that prevents (web) screen readers from pressing buttons through keyboard shortcuts.
+- [flutter/173960](https://github.com/flutter/flutter/issues/173960) - Fixes an issue where starting a widget preview fails if Chrome or Edge is not installed.
+- [flutter/174017](https://github.com/flutter/flutter/issues/174017) - Fixes an issue when running a 32-bit process on a 64-bit Windows system.
+- [flutter/173895](https://github.com/flutter/flutter/issues/173895) - Don't crash widget preview when a directory watcher restarts on Windows.
+- [flutter/171992](https://github.com/flutter/flutter/issues/171992) - Blocks `exynos9820` chip from using the Impeller Vulkan backend.
+- [flutter/173959](https://github.com/flutter/flutter/issues/173959) - Fixes a null assertion when trying to add `@Preview()` to invalid nodes.
+- [flutter/174184](https://github.com/flutter/flutter/pull/174184) - Fixes an issue where WASM builds were incorrectly triggered when dry run is disabled and --wasm is not specified.
+- [flutter/171758](https://github.com/flutter/flutter/issues/171758) - Fixes an ExistingDartDevelopmentServiceException that could be thrown when running flutter run on a device with an existing Dart development service.
+
+### [3.35.1](https://github.com/flutter/flutter/releases/tag/3.35.1)
+
+- [flutter/173785](https://github.com/flutter/flutter/issues/173785) - Fixes an issue that prevented downloading the Flutter SDK for Windows from `flutter.dev`.
+
+### [3.35.0](https://github.com/flutter/flutter/releases/tag/3.35.0)
+
+Initial stable release.
+
 ## Flutter 3.32 Changes
 
 ### [3.32.8](https://github.com/flutter/flutter/releases/tag/3.32.8)

CODEOWNERS

@@ -12,19 +12,8 @@
 /packages/flutter_tools/lib/src/ios/ @vashworth
 
 # Internal dev infra that is closely tied to team-infra.
-/bin/internal/update_engine_version.ps1 @matanlurey
-/bin/internal/update_engine_version.sh @matanlurey
-/dev/bots/** @matanlurey
-/dev/conductor/** @matanlurey
-/dev/devicelab/** @matanlurey
-/dev/tools/test/update_engine_version_test.dart @matanlurey
-
-# flutter_drver, integration_test. Intentionally omit root files (i.e. pubspec.yaml upgrades).
-/dev/tools/android_driver_extensions @matanlurey
-/packages/flutter_driver/lib/** @matanlurey
-/packages/flutter_driver/test/** @matanlurey
-/packages/integration_test/lib/** @matanlurey
-/packages/integration_test/test/** @matanlurey
+/bin/internal/** @jtmcdole
+/dev/tools/test/** @jtmcdole
 
 # The following files define an Application Binary Interface (ABI) that must maintain
 # both forward and backward compatibility. Changes should be heavily

CONTRIBUTING.md

@@ -106,7 +106,7 @@ that describe these methodologies. The following list is ordered: you
 are strongly recommended to go through these documents in the order
 presented.
 
-1. [Setting up your engine development environment](./engine/src/flutter/docs/contributing/Setting-up-the-Engine-development-environment.md),
+1. [Setting up your engine development environment](./docs/engine/contributing/Setting-up-the-Engine-development-environment.md),
    which describes the steps you need to configure your computer to
    work on Flutter's engine. If you only want to write code for the
    Flutter framework, you can skip this step. Flutter's engine mainly