fix: Add livenessProbe to workload pod #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
force-pushed
the
kf-5956-add-liveness-probe
branch
from
cc2be41
to
d1b59db
Compare
NohaIhab
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
I have tried deploying the charm from this PR, and in my case the check actually failed in the beginning and I was able to see the container restart:
NAME READY STATUS RESTARTS AGE
envoy-d677f758-r4qxj 1/1 Running 1 (2h ago) 2h
After that, the workload is functioning correctly
LGTM, thanks @orfeas-k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the condition from integration tests as a
livenessProbeto the workload container in order to ensure that the workload container restarts if it's not functional.Closes canonical/bundle-kubeflow#966