Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ops to version 2.3.0 #76

Closed
wants to merge 1 commit into from
Closed

Pin ops to version 2.3.0 #76

wants to merge 1 commit into from

Conversation

arturo-seijas
Copy link
Collaborator

@arturo-seijas arturo-seijas commented Jul 5, 2023

Pin ops to version 2.3.0

@arturo-seijas arturo-seijas changed the title Fix linting Pin ops to version 2.3.0 Jul 5, 2023
Copy link
Contributor

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what is the reason for the pin? Is there a bug with later versions?

@arturo-seijas
Copy link
Collaborator Author

Out of curiosity, what is the reason for the pin? Is there a bug with later versions?

There's a breaking change. Will update the dependency later

Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Test coverage for 48d4810

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py     241     22     70      5    90%   410-412, 455-457, 460->exit, 470->exit, 491->exit, 504-516, 544-550, 576->exit, 590-591
----------------------------------------------------------
TOTAL            241     22     70      5    90%

Static code analysis report

Run started:2023-07-05 16:04:27.059145

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1552
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@arturo-seijas arturo-seijas deleted the fix-linting branch July 10, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants