Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a rockfile to replace the current Dockerfile #75

Merged
merged 19 commits into from
Sep 14, 2023
Merged

Conversation

nrobinaubertin
Copy link
Collaborator

@nrobinaubertin nrobinaubertin commented Jun 26, 2023

Overview

The goal of this PR is to replace the current dockerfile with a rockfile.

Notes:

  • I decided to not use a bare base, opting for simplicity for now. In the same spirit, I'm using the root user at runtime.
  • The integration tests rely on this draft PR so that means that it's not really mergeable until the latter is.
  • Integration tests rely on raise_on_error=False sometimes, I want to work on this in a further PR.

Checklist

tests/integration/conftest.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
rockcraft.yaml Outdated Show resolved Hide resolved
rockcraft.yaml Outdated Show resolved Hide resolved
@nrobinaubertin nrobinaubertin marked this pull request as ready for review August 24, 2023 19:33
@nrobinaubertin nrobinaubertin requested a review from a team as a code owner August 24, 2023 19:33
@nrobinaubertin nrobinaubertin changed the title (WIP) Create a rockfile to replace the current Dockerfile Create a rockfile to replace the current Dockerfile Aug 24, 2023
merkata
merkata previously approved these changes Aug 25, 2023
src/charm.py Outdated Show resolved Hide resolved
weiiwang01
weiiwang01 previously approved these changes Aug 28, 2023
@nrobinaubertin nrobinaubertin dismissed stale reviews from weiiwang01 and merkata via b55c1de August 30, 2023 12:00
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Test coverage for 6789e5d

Name              Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------
src/charm.py        250     17     70      9    92%   128, 137, 145, 285->290, 484-486, 529-531, 534->exit, 541-542, 544->exit, 551, 579-585, 611->exit, 625-626
src/database.py      30      1      8      1    95%   56
-------------------------------------------------------------
TOTAL               280     18     78     10    92%

Static code analysis report

Run started:2023-09-14 12:30:08.627269

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1775
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@nrobinaubertin nrobinaubertin merged commit b9a66d9 into main Sep 14, 2023
29 checks passed
@nrobinaubertin nrobinaubertin deleted the rockfile branch September 14, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants