-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a rockfile to replace the current Dockerfile #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrobinaubertin
force-pushed
the
rockfile
branch
from
August 2, 2023 13:45
c849efc
to
b27f0f7
Compare
nrobinaubertin
force-pushed
the
rockfile
branch
from
August 10, 2023 18:08
c784b8b
to
860f014
Compare
This reverts commit a32e7fa.
nrobinaubertin
changed the title
(WIP) Create a rockfile to replace the current Dockerfile
Create a rockfile to replace the current Dockerfile
Aug 24, 2023
merkata
previously approved these changes
Aug 25, 2023
weiiwang01
previously approved these changes
Aug 28, 2023
nrobinaubertin
dismissed stale reviews from weiiwang01 and merkata
via
August 30, 2023 12:00
b55c1de
weiiwang01
approved these changes
Sep 14, 2023
arturo-seijas
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test coverage for 6789e5d
Static code analysis report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The goal of this PR is to replace the current dockerfile with a rockfile.
Notes:
bare
base, opting for simplicity for now. In the same spirit, I'm using the root user at runtime.raise_on_error=False
sometimes, I want to work on this in a further PR.Checklist
src-docs
urgent
,trivial
,complex
)