Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linters: migrate from flake8 to ruff #337

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Dec 16, 2022

This configures ruff and sets it to the default, while still giving
developers the option to run flake8 if they choose using
make test-flake8
CRAFT-1506

* Adds ruff option to Makefile, switches references to flake8 -> ruff
* Make setup.py require ruff rather than flake8
* Make GitHub linting workflow use ruff
* Detailed ruff config in pyproject.toml
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

pyproject.toml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@lengau lengau changed the title Migrate from flake8 to ruff Tooling: migrate from flake8 to ruff Dec 16, 2022
@lengau lengau changed the title Tooling: migrate from flake8 to ruff Linters: migrate from flake8 to ruff Dec 16, 2022
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tigarmo tigarmo merged commit 487e049 into canonical:main Dec 16, 2022
@lengau lengau deleted the craft-1506/flake8-to-ruff branch February 1, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants