Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix untyped-defs on /tests/unittest/cmd #5800

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

wideawakening
Copy link
Contributor

@wideawakening wideawakening commented Oct 8, 2024

related to #5445

effort has been timeboxed, as part of the onboarding.

  • tests.unittests.cmd.devel.test_hotplug_hook
  • tests.unittests.cmd.devel.test_render
  • tests.unittests.cmd.test_clean
  • tests.unittests.cmd.test_query
  • tests.unittests.cmd.test_status

Proposed Commit Message

lint: fix untyped-defs on /tests/unittest/cmd

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@wideawakening wideawakening changed the title lint: fix untyped-defs on /test/unittest/cmd lint: fix untyped-defs on /tests/unittest/cmd Oct 8, 2024
@holmanb
Copy link
Member

holmanb commented Oct 8, 2024

Hi @wideawakening o/

Thanks for contributing to cloud-init. This looks like a great first addition to cloud-init. Can you please sign the CLA so we can accept this contribution?

@wideawakening
Copy link
Contributor Author

wideawakening commented Oct 9, 2024

Can you please sign the CLA so we can accept this contribution?

hey, sure. should had been accepted already

@aciba90 aciba90 added the CLA signed The submitter of the PR has signed the CLA label Oct 9, 2024
Copy link
Contributor

@aciba90 aciba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Many thanks for making cloud-init better, welcome!

tests/unittests/cmd/devel/test_hotplug_hook.py Outdated Show resolved Hide resolved
@aciba90 aciba90 merged commit 5d2ff73 into canonical:main Oct 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed The submitter of the PR has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants