feat(byobu/locale): install necessary packages when absent in images and cloud-config user-data wants to setup #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackboxsw
added a commit
to blackboxsw/cloud-init
that referenced
this pull request
Oct 8, 2024
blackboxsw
force-pushed
the
SC-1750-lxd-minimal-integration-testing
branch
from
1728520
to
2376872
Compare
blackboxsw
changed the title
cloudinit/distros/debian.py
Outdated
| @@ -282,7 +296,7 @@ def update_locale_conf(locale, sys_path, keyname="LANG"): | |||
| ) | |||
|
|
|||
|
|
|||
| def regenerate_locale(locale, sys_path, keyname="LANG"): | |||
| def regenerate_locale(locale, sys_path, keyname="LANG", install_callback=None): | |||
There was a problem hiding this comment.
Why are we passing an install function here rather than calling self.install_packages in the body?
Nit: I also wouldn't call this a callback
There was a problem hiding this comment.
@TheRealFalcon do you mean do the subp.which call and install_packages up in Distro.apply_locale?The regenerate_locale and update_locale_conf are functions which aren't defined on the class. Rather than pulling that function up into the class as a method, I chose to pass the Distro.install_packages function into those helpers. If you think it makes more sense (because we are using self.install_packages) to pull regenerate_locale and update_locale_conf up into the debian.Distro class I can do that instead.
blackboxsw
added a commit
to blackboxsw/cloud-init
that referenced
this pull request
Oct 8, 2024
blackboxsw
force-pushed
the
SC-1750-lxd-minimal-integration-testing
branch
from
2376872
to
84623e6
Compare
TheRealFalcon
approved these changes
Oct 8, 2024
blackboxsw
force-pushed
the
SC-1750-lxd-minimal-integration-testing
branch
from
84623e6
to
fd16cfb
Compare
blackboxsw
added a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase as separate commits
Install the necessary package dependencies (byobu or locales) when cloud-config directives provide configuration requesting setup and config of byobu or locales.
Addresses issues with minimal images not containing byobu or locales packages, yet user-data requests that specific setup and configuration.
Proposed Commit Message(s)
Additional Context
Failed jenkins job on ubuntu minimal
https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-integration-noble-lxd_container-minimal/lastSuccessfulBuild/
Test Steps
Merge type