Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oracle ipv6 single stack imds functionality #5785

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

a-dubs
Copy link
Collaborator

@a-dubs a-dubs commented Oct 4, 2024

Proposed Commit Message

N/A

We rebasing 😎

Additional Context

This is to enable future functionality on the Oracle Cloud and will have no immediate ramifications or generally available use cases for the meantime.

Test Steps

These changes were manually tested on both jammy (22.04) and noble (24.04), on Oracle Platform Ubuntu images for testing ipv4 and dual stack, and then on custom built images for ipv6 single stack testing. For this manual validation, the following things were checked:

  • No new warnings logged vs unmodified cloud-init package
  • No boot speed slowdowns introduced vs unmodified cloud-int package

The new oracle single-stack ipv6 integration tests was run against an existing instance with the following command:

CLOUD_INIT_EXISTING_INSTANCE_ID="ocid1.instance............" \
CLOUD_INIT_PLATFORM="oci" \
CLOUD_INIT_RUN_UNSTABLE="true" \
CLOUD_INIT_KEEP_INSTANCE="true" \
tox -e integration-tests -- \
tests/integration_tests/datasources/test_oracle_ipv6.py

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@a-dubs a-dubs changed the title Cpc 3194 oracle ipv6 single stack add oracle ipv6 single stack imds functionality Oct 4, 2024
@a-dubs a-dubs force-pushed the CPC-3194-oracle-ipv6-single-stack branch 6 times, most recently from 6384321 to df66386 Compare October 10, 2024 15:03
@a-dubs a-dubs force-pushed the CPC-3194-oracle-ipv6-single-stack branch 4 times, most recently from c8842ba to 3d1941e Compare October 10, 2024 22:04
@a-dubs a-dubs force-pushed the CPC-3194-oracle-ipv6-single-stack branch from 3d1941e to f207b2a Compare October 10, 2024 22:07
@a-dubs a-dubs marked this pull request as ready for review October 10, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant