Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix tox.ini pytest cmd to use cloudinit dir for coverage reporting #5774

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

a-dubs
Copy link
Collaborator

@a-dubs a-dubs commented Oct 3, 2024

Proposed Commit Message

ci: fix tox.ini pytest cmd to use cloudinit dir for coverage reporting

Additional Context

Test Steps

Run the following locally to run pytest and ensure that the coverage report table appears at the end of the pytest results:

tox -e py3

Then, run the following new tox command to re-print the table to console:

tox -e coverage-report

Then, run the following new tox command to generate the html coverage site.

tox -e converage-html

Optional: Open automagically with xdg-open:

xdg-open htmlcov/index.html

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

The src code directory for checking code coverage in was erroneously
set to "cloud-init" instead of "cloudinit". This prevented unit test
coverage from being gathered and reported.
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit f9082bf into canonical:main Oct 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants