Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements test multi nic hotplug #5763

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Improvements test multi nic hotplug #5763

merged 2 commits into from
Oct 1, 2024

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Oct 1, 2024 •
edited
Loading

See individual commits for more context.

Additional Context

Test Steps

export CLOUD_INIT_CLOUD_INIT_SOURCE=./cloud-init_all.deb
export CLOUD_INIT_PLATFORM=ec2

tox -re integration-tests -- -vvv --pdb tests/integration_tests/modules/test_hotplug.py::test_multi_nic_hotplug

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@aciba90
test(hotplug): increase nc timeout (canonical#5763)
14e6a6f 
Increase timeout check in netcat command for test_multi_nic_hotplug, as
there are instances where the 5s timeout is not enough.
aciba90 added a commit to aciba90/cloud-init that referenced this pull request Oct 1, 2024
@aciba90
test(hotplug): Simplify test_multi_nic_hotplug (canonical#5763)
984b9ab 
No functional test, just noop simplification of the test code.
@aciba90 aciba90 force-pushed the improvements-test-multi-nic-hotplug branch from d536205 to 984b9ab Compare October 1, 2024 12:14
aciba90 added a commit to aciba90/cloud-init that referenced this pull request Oct 1, 2024
@aciba90
test(hotplug): Simplify test_multi_nic_hotplug (canonical#5763)
94276a1 
No functional test, just noop simplification of the test code.
@aciba90 aciba90 force-pushed the improvements-test-multi-nic-hotplug branch from 984b9ab to 94276a1 Compare October 1, 2024 12:16
@aciba90 aciba90 marked this pull request as ready for review October 1, 2024 12:18
TheRealFalcon
TheRealFalcon approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aciba90
test(hotplug): Simplify test_multi_nic_hotplug (canonical#5763)
8e48c23 
No functional test, just noop simplification of the test code.
@aciba90 aciba90 force-pushed the improvements-test-multi-nic-hotplug branch from 94276a1 to 8e48c23 Compare October 1, 2024 12:56
@aciba90 aciba90 merged commit dc3cfde into canonical:main Oct 1, 2024
21 checks passed
aciba90 added a commit that referenced this pull request Oct 1, 2024
@aciba90
test(hotplug): increase nc timeout (#5763)
ff336d4 
Increase timeout check in netcat command for test_multi_nic_hotplug, as
there are instances where the 5s timeout is not enough.
@aciba90 aciba90 deleted the improvements-test-multi-nic-hotplug branch October 1, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aciba90 @TheRealFalcon