Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ci dependency versions #5660

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Sep 3, 2024

Proposed Commit Message

chore: bump ci dependency versions

- use canonical/lxd in integration test
- optimize integration test to run faster

Additional Context

#5658

@holmanb holmanb added the wip Work in progress, do not land label Sep 4, 2024
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to keep unit tests on earliest ubuntu, not latest. Us devs are generally all running latest, so I think it helps with additional coverage. We have the 'lowest supported' job, but it winds up being more of an approximation.

.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Show resolved Hide resolved
@holmanb
Copy link
Member Author

holmanb commented Sep 4, 2024

I would prefer to keep unit tests on earliest ubuntu, not latest. Us devs are generally all running latest, so I think it helps with additional coverage. We have the 'lowest supported' job, but it winds up being more of an approximation.

Tests currently run on Jammy which is neither earliest nor latest. Would you rather we drop the release it from Jammy down to Focal?

My only counterpoint is that as part of Canonical we're better equipped to dogfood new versions so I'd lean towards early adoption since our internal CI infrastructure gets us unittest coverage as part of package build for integration testing.

That said, I really don't think it matters what version of Ubuntu we're on, because for unit tests we use actions/setup-python, and install tox via pip, so I don't see any system dependencies being used anyways.

@holmanb holmanb removed the wip Work in progress, do not land label Sep 4, 2024
@TheRealFalcon
Copy link
Member

That said, I really don't think it matters what version of Ubuntu we're on, because for unit tests we use actions/setup-python, and install tox via pip, so I don't see any system dependencies being used anyways.

Good point, +1.

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and one ask inline, but +1 either way.

.github/workflows/integration.yml Outdated Show resolved Hide resolved
.github/workflows/integration.yml Outdated Show resolved Hide resolved
@holmanb holmanb merged commit 82efd3e into canonical:main Sep 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants