Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu/devel #4789

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Ubuntu/devel #4789

merged 2 commits into from
Jan 22, 2024

Conversation

blackboxsw
Copy link
Collaborator

@blackboxsw blackboxsw commented Jan 20, 2024

Rebase merge separate commits. Blocked on config review of #4790

Add logrotate functionality to ubuntu downstream packaging.

Separate changelog update from logrotate addition for ease of cherry-pick to other downstream branches.

Additional Context

Jenkins integration tests now fail due to landing 0e247c8 because no logrotate file is yet delivered in the cloud-init daily PPA packages built. After t

Test Steps

# to see failures locally
CLOUD_INIT_KEEP_INSTANCE=1 CLOUD_INIT_CLOUD_INIT_SOURCE=ppa:cloud-init-dev/daily CLOUD_INIT_OS_IMAGE=lunar CLOUD_INIT_PLATFORM=lxd_container tox -e integration-tests -- tests/integration_tests/cmd/test_clean.py::TestCleanCommand::test_clean_rotated_logs

The above fails because no logrotate.d file is yet delivered by cloud-init deb package in our daily builds.
A followup PR to ubuntu/devel will be pushed containing the agreed upon logrotate.d config to ensure upstream matches what we are delivering in ubuntu.

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@blackboxsw blackboxsw changed the base branch from main to ubuntu/devel-23.1.x January 20, 2024 03:34
@blackboxsw blackboxsw changed the base branch from ubuntu/devel-23.1.x to ubuntu/devel January 20, 2024 03:34
Copy link
Contributor

@aciba90 aciba90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blackboxsw blackboxsw merged commit ce84e73 into canonical:ubuntu/devel Jan 22, 2024
21 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants