Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable coverage in integration tests #4682

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Enable coverage in integration tests #4682

merged 4 commits into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. docs: fix cloud-init single param docs (canonical#4682)

    @TheRealFalcon
    TheRealFalcon committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3e00e4d View commit details
    Browse the repository at this point in the history

  2. test: Remove snapshot option from install_new_cloud_init (canonical#4682 

    )

Integration tests allow for installing a new version of cloud-init with
the option of snapshotting the image after install. After taking
a snapshot, it will then set the snapshot as the default for *all*
future launches in this test run. This is also used by the conftest to
setup the initial image, but it should not be used anywhere else.

Rather than having it as an option to the install_new_cloud_init method,
remove the option and make the confest set the global snapshot instead.
This removes a footgun when writing other tests that need to install a
different version of cloud-init.
    @TheRealFalcon
    TheRealFalcon committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    619cff6 View commit details
    Browse the repository at this point in the history

  3. test: Move unit test helpers to global test helpers (canonical#4682) 

    `get_top_level_dir` and `cloud_init_project_dir` have uses in
integration tests. Move them up to a top-level test helper file
accordingly.
    @TheRealFalcon
    TheRealFalcon committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    9265772 View commit details
    Browse the repository at this point in the history

  4. test: Enable coverage in integration tests (canonical#4682)

    @TheRealFalcon
    TheRealFalcon committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    673bb73 View commit details
    Browse the repository at this point in the history