Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud-init Broken with jsonschema 4.21.0 #4783

Closed
holmanb opened this issue Jan 17, 2024 · 3 comments
Closed

Cloud-init Broken with jsonschema 4.21.0 #4783

holmanb opened this issue Jan 17, 2024 · 3 comments
Assignees
Labels
bug Something isn't working correctly

Comments

@holmanb
Copy link
Member

holmanb commented Jan 17, 2024

Bug report

I got CI working again in #4781, but we really should update our tests and make sure that the behavior that changed isn't something that actually breaks cloud-init.

Steps to reproduce the problem

Run unittests with latest jsonschema.

@holmanb holmanb added bug Something isn't working correctly new An issue that still needs triage 24.1 labels Jan 17, 2024
@TheRealFalcon
Copy link
Member

They changed some error messages and our tests were checking for specific error messages:
python-jsonschema/jsonschema@8875c2e
python-jsonschema/jsonschema@a1d4cb3

Given that we'll have to support multiple versions of jsonschema across series, we either need to not check for a specific error message or check that we match either message.

@dermotbradley
Copy link
Contributor

I'm now hitting this issue locally with my testing of Alpine cloud-init packaging (which I use for ongoing cloud-init development) as Alpine updated their py3-jsonschema package to version 4.21.1 last week...

@blackboxsw blackboxsw removed the new An issue that still needs triage label Jan 22, 2024
@dermotbradley
Copy link
Contributor

@TheRealFalcon here's a diff of what I had to apply locally to get cloud-init tests passing with the latest py3-jsonschema: https://gist.github.com/dermotbradley/45f2987c9da4d2ad11e8374ba13f4062

I didn't raise a PR as this doesn't cover backwards-compatibility.

@TheRealFalcon TheRealFalcon self-assigned this Feb 13, 2024
TheRealFalcon added a commit to TheRealFalcon/cloud-init that referenced this issue Feb 14, 2024
In 034a5cd , we pinned jsonschema version due to failing tests. Test
failures were due to jsonschema library changing error messages.
This commit unpins the version and updates tests accordingly.

Fixes canonicalGH-4783

Co-authored-by: dermotbradley <[email protected]>
TheRealFalcon added a commit to TheRealFalcon/cloud-init that referenced this issue Feb 14, 2024
In 034a5cd , we pinned jsonschema version due to failing tests. Test
failures were due to jsonschema library changing error messages.
This commit unpins the version and updates tests accordingly.

Fixes canonicalGH-4783

Co-authored-by: dermotbradley <[email protected]>
blackboxsw pushed a commit that referenced this issue Feb 15, 2024
In 034a5cd , we pinned jsonschema version due to failing tests. Test
failures were due to jsonschema library changing error messages.
This commit unpins the version and updates tests accordingly.

Fixes GH-4783

Co-authored-by: dermotbradley <[email protected]>
blackboxsw pushed a commit that referenced this issue Feb 15, 2024
In 034a5cd , we pinned jsonschema version due to failing tests. Test
failures were due to jsonschema library changing error messages.
This commit unpins the version and updates tests accordingly.

Fixes GH-4783

Co-authored-by: dermotbradley <[email protected]>
blackboxsw pushed a commit that referenced this issue Feb 16, 2024
In 034a5cd , we pinned jsonschema version due to failing tests. Test
failures were due to jsonschema library changing error messages.
This commit unpins the version and updates tests accordingly.

Fixes GH-4783

Co-authored-by: dermotbradley <[email protected]>
blackboxsw pushed a commit that referenced this issue Feb 16, 2024
In 034a5cd , we pinned jsonschema version due to failing tests. Test
failures were due to jsonschema library changing error messages.
This commit unpins the version and updates tests accordingly.

Fixes GH-4783

Co-authored-by: dermotbradley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants