-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud-init Broken with jsonschema 4.21.0 #4783
Comments
They changed some error messages and our tests were checking for specific error messages: Given that we'll have to support multiple versions of jsonschema across series, we either need to not check for a specific error message or check that we match either message. |
I'm now hitting this issue locally with my testing of Alpine cloud-init packaging (which I use for ongoing cloud-init development) as Alpine updated their py3-jsonschema package to version 4.21.1 last week... |
@TheRealFalcon here's a diff of what I had to apply locally to get cloud-init tests passing with the latest py3-jsonschema: https://gist.github.com/dermotbradley/45f2987c9da4d2ad11e8374ba13f4062 I didn't raise a PR as this doesn't cover backwards-compatibility. |
In 034a5cd , we pinned jsonschema version due to failing tests. Test failures were due to jsonschema library changing error messages. This commit unpins the version and updates tests accordingly. Fixes canonicalGH-4783 Co-authored-by: dermotbradley <[email protected]>
In 034a5cd , we pinned jsonschema version due to failing tests. Test failures were due to jsonschema library changing error messages. This commit unpins the version and updates tests accordingly. Fixes canonicalGH-4783 Co-authored-by: dermotbradley <[email protected]>
In 034a5cd , we pinned jsonschema version due to failing tests. Test failures were due to jsonschema library changing error messages. This commit unpins the version and updates tests accordingly. Fixes GH-4783 Co-authored-by: dermotbradley <[email protected]>
In 034a5cd , we pinned jsonschema version due to failing tests. Test failures were due to jsonschema library changing error messages. This commit unpins the version and updates tests accordingly. Fixes GH-4783 Co-authored-by: dermotbradley <[email protected]>
In 034a5cd , we pinned jsonschema version due to failing tests. Test failures were due to jsonschema library changing error messages. This commit unpins the version and updates tests accordingly. Fixes GH-4783 Co-authored-by: dermotbradley <[email protected]>
In 034a5cd , we pinned jsonschema version due to failing tests. Test failures were due to jsonschema library changing error messages. This commit unpins the version and updates tests accordingly. Fixes GH-4783 Co-authored-by: dermotbradley <[email protected]>
Bug report
I got CI working again in #4781, but we really should update our tests and make sure that the behavior that changed isn't something that actually breaks cloud-init.
Steps to reproduce the problem
Run unittests with latest jsonschema.
The text was updated successfully, but these errors were encountered: