Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate manifest before writing #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: validate manifest before writing #159

wants to merge 1 commit into from

Conversation

letFunny
Copy link
Collaborator

@letFunny letFunny commented Oct 2, 2024

  • Have you signed the CLA?

rebornplusplus
rebornplusplus reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I left a comment below about a function name.

internal/manifest/manifest.go
@@ -301,3 +306,104 @@ func unixPerm(mode fs.FileMode) (perm uint32) {
}
return perm
}

func fastValidate(options *WriteOptions) (err error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably name this something else. How about validateOptions, or preValidateManifest? Or, something else along that line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment would be nice here as well. :)

@letFunny letFunny added the Priority Look at me first label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebornplusplus rebornplusplus rebornplusplus left review comments

Assignees
No one assigned
Labels
Priority Look at me first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@letFunny @rebornplusplus