Fix race condition in reboot_check_test's renderer test and add lsusb/lspci timeout (BugFix) #1671
+108
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved issues
Race condition issue: #1631
There was also an issue reported by Hanhsuan where lspci and lsusb can get stuck and never return, so I added a timeout for their
subprocess.run
calls.Documentation
The wait timeout can be controlled by
--graphical-target-timeout <timeout_seconds>
. This value is ignored when-g
or--graphics
are not specified. Default is 120 secondsTests
Unit tests