Security scanning zizmor (infra) #1668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor: Fix checkbox->Checkbox
This was done in response to a vulnerability: codecov has a branch that is v3 and a tag, so any commit to the v3 branch can steal the token potentially
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
=======================================
Coverage 48.99% 48.99%
=======================================
Files 372 372
Lines 40321 40321
Branches 6811 6811
=======================================
Hits 19757 19757
Misses 19842 19842
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a new workflow to do sistematic vulnerability scanning of our PRs. This is not a silver bullet, as it will be ran only when new workflows are introduced or old ones are modified but its a good start.
This also adjusts all "problems" found by the tool so that it passes all the times now namely:
Resolved issues
Fixes: CHECKBOX-1706
Documentation
N/A
Tests
Tested tox action to check that the new codecov action works: https://github.com/canonical/checkbox/actions/runs/12431986975