-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The mermaid diagram is not shown on Description (the content from Discourse) #1525
Comments
Hint: if you wish to publish mermaid on charmhub: publish screenshots with links to GitHub, e.g. https://charmhub.io/postgresql-k8s/docs/e-charm?channel=14/stable |
We do not want to loose mermaid diagrams on GitHub, we are waiting for mermaid support on Discource: canonical/charmhub.io#1525
I believe this is no longer relevant since we made this change. Closing, but please reopen if you think it's still relevant :). |
* [MISC] Sync from Discourse * Restore original docs/explanation/e-flowcharts.md We do not want to loose mermaid diagrams on GitHub, we are waiting for mermaid support on Discource: canonical/charmhub.io#1525 --------- Co-authored-by: Alex Lutay <[email protected]>
Dear @Lukewh , it is still relevant for Data Platform team. Please see the following examples: As you can see we are actively using mermaid diagrams to describe the internal logic of our charms. We really looking forward to add mermaid support for charmhub.io (as Discourse supports mermaid nowadays). |
Aha, I see. I'll reopen and rename this issue to relate to discourse rendering, not GitHub README rendering 👍 |
@taurus-forever this is now live, and you can see the resulting diagram on https://charmhub.io/mysql-k8s/docs/e-flowcharts :). |
You are my HERO! Thank YOU!!! |
@Lukewh there is a small bug (if page has 2+ diagrams): https://charmhub.io/postgresql-k8s/docs/e-charm |
Please do! I'll take a look anyway, but good to track it separately :) |
@taurus-forever never mind, already merged: #1586 :) |
The fix confirmed, thank you one more time! |
Hi,
Please check mysql-router on charmhub.io: https://charmhub.io/mysql-router?channel=dpe/edge
and on GitHub: https://github.com/canonical/mysql-router-operator/blob/main/README.md
As you can see the basic mermaid diagram is not processed on charmhub.io and shown as a plain text:
flowchart TD...
It looks like https://warthogs.atlassian.net/browse/WD-665 was a subtask for develop mermaid support.
Is it a not-yet implemented feature or a bug? Thank you!
P.S. we would like to publish more complex diagrams, but without charmhub.io support mermaid is a risky choice.
The text was updated successfully, but these errors were encountered: