[MISC] Fix build workflow #16
Conversation
.github/workflows/build.yaml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| version=$(yq '(.version|split("-"))[0]' rockcraft.yaml) | |||
| base=$(yq '(.base|split(":"))[1]' rockcraft.yaml) | |||
| tag=${version}-${base}_edge | |||
| sed -i "s/${app_version}/${tag}/g" rockcraft.yaml | |||
| sed -i "s/${app_version}/${base}/g" rockcraft.yaml | |||
There was a problem hiding this comment.
Underscore no longer accepted. Do we really need to change the version on the fly?
There was a problem hiding this comment.
re: Do we really need to change the version on the fly?
Otherwise how to set OCI factory compatible version/tag (8.0.33-22.04_edge)?
There was a problem hiding this comment.
Otherwise how to set OCI factory compatible version/tag (
8.0.33-22.04_edge)?
The registry tag is set in the publish workflow here. I don't think we need to change the version in rockcraft.yaml at all with our current release pipeline.
There was a problem hiding this comment.
I am not sure why it is here. BTW, MongoDB ROCK is not touching it: https://github.com/canonical/charmed-mongodb-rock/blob/5-22.04/.github/workflows/publish.yaml
There was a problem hiding this comment.
Following up on MM discussion, will remove the update to rockcraft.yaml and see how it goes.
| @@ -1,5 +1,5 @@ | |||
| name: charmed-postgresql # the name of your ROCK | |||
| base: ubuntu:22.04 # the base environment for this ROCK | |||
| base: ubuntu@22.04 # the base environment for this ROCK | |||
There was a problem hiding this comment.
Dots in deprecated.
There was a problem hiding this comment.
@shayancanonical JFYI, re: MySQL ROCK.
|
@taurus-forever I think this will affect rebuilds of the Mysql Rock as well. |
| @@ -1,5 +1,5 @@ | |||
| name: charmed-postgresql # the name of your ROCK | |||
| base: ubuntu:22.04 # the base environment for this ROCK | |||
| base: ubuntu@22.04 # the base environment for this ROCK | |||
There was a problem hiding this comment.
@shayancanonical JFYI, re: MySQL ROCK.
.github/workflows/build.yaml
Outdated
| @@ -23,7 +23,7 @@ jobs: | |||
| version=$(yq '(.version|split("-"))[0]' rockcraft.yaml) | |||
| base=$(yq '(.base|split(":"))[1]' rockcraft.yaml) | |||
| tag=${version}-${base}_edge | |||
| sed -i "s/${app_version}/${tag}/g" rockcraft.yaml | |||
| sed -i "s/${app_version}/${base}/g" rockcraft.yaml | |||
There was a problem hiding this comment.
re: Do we really need to change the version on the fly?
Otherwise how to set OCI factory compatible version/tag (8.0.33-22.04_edge)?
Rock refuses to pack with latest rockcraft