Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove state #55

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Remove state #55

merged 3 commits into from
Mar 17, 2025

Conversation

waveform80
Copy link
Member

Per #53, the :state: option is actually useless and should be removed.

It doesn't make any sense to have this as any unsupported release has no
corresponding directories on cdimage and so we can never produce output
for them anyway.

We also have the :empty: option now to include messages in the case that
no supported releases are found (e.g. if the devel release is the only
matching one).

Fixes: canonical#53
@waveform80
Copy link
Member Author

Also included the tests for :empty: which I'd forgotten to write!

Copy link
Collaborator

@SecondSkoll SecondSkoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SecondSkoll SecondSkoll merged commit 2734b01 into canonical:main Mar 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants